i2c: Encourage move to dev_pm_ops by warning on use of legacy methods (f4e8db31) · Commits · 戴 / test

Since the PM core wishes to transition away from the legacy suspend and resume methods and since removing them makes using PM core features like runtime PM much easier start warning when a driver is registered using the legacy methods. Signed-off-by:

Mark Brown <broonie@opensource.wolfsonmicro.com> Signed-off-by:

Jean Delvare <khali@linux-fr.org>

drivers/i2c/i2c-core.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -1124,6 +1124,14 @@ int i2c_register_driver(struct module owner, struct i2c_driver driver)
		if (res)
		return res;

		/* Drivers should switch to dev_pm_ops instead. */
		if (driver->suspend)
		pr_warn("i2c-core: driver [%s] using legacy suspend method\n",
		driver->driver.name);
		if (driver->resume)
		pr_warn("i2c-core: driver [%s] using legacy resume method\n",
		driver->driver.name);

		pr_debug("i2c-core: driver [%s] registered\n", driver->driver.name);

		INIT_LIST_HEAD(&driver->clients);

Admin message