Input: i8042 - remove unneeded call to i8042_interrupt() (f4e3c711) · Commits · 戴 / test

Remove call to i8042_interrupt() from i8042_aux_write(). According to Vojtech it may cause problems with older controllers if it is called right after real interrupt. Also it is not needed anymore since we register IRQs early and not waiting for serio ports to be opened. Signed-off-by:

Dmitry Torokhov <dtor@mail.ru>

drivers/input/serio/i8042.c

+3 −18

Original line number	Diff line number	Diff line
		@@ -255,25 +255,10 @@ static int i8042_kbd_write(struct serio *port, unsigned char c)
		static int i8042_aux_write(struct serio *serio, unsigned char c)
		{
		struct i8042_port *port = serio->port_data;
		int retval;

		/*
		* Send the byte out.
		*/

		if (port->mux == -1)
		retval = i8042_command(&c, I8042_CMD_AUX_SEND);
		else
		retval = i8042_command(&c, I8042_CMD_MUX_SEND + port->mux);

		/*
		* Make sure the interrupt happens and the character is received even
		* in the case the IRQ isn't wired, so that we can receive further
		* characters later.
		*/

		i8042_interrupt(0, NULL);
		return retval;
		return i8042_command(&c, port->mux == -1 ?
		I8042_CMD_AUX_SEND :
		I8042_CMD_MUX_SEND + port->mux);
		}

		/*

Admin message