Commit f4de93f0 authored by Claudiu Beznea's avatar Claudiu Beznea Committed by David S. Miller
Browse files

net: macb: unprepare clocks in case of failure 



Unprepare clocks in case of any failure in fu540_c000_clk_init().

Fixes: c218ad55 ("macb: Add support for SiFive FU540-C000")
Signed-off-by: default avatarClaudiu Beznea <claudiu.beznea@microchip.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 38493da4

drivers/net/ethernet/cadence/macb_main.c

+18 −6
Original line number Diff line number Diff line
@@ -4420,8 +4420,10 @@ static int fu540_c000_clk_init(struct platform_device *pdev, struct clk **pclk, 
		return err;



	mgmt = devm_kzalloc(&pdev->dev, sizeof(*mgmt), GFP_KERNEL);

	if (!mgmt)

		return -ENOMEM;

	if (!mgmt) {

		err = -ENOMEM;

		goto err_disable_clks;

	}



	init.name = "sifive-gemgxl-mgmt";

	init.ops = &fu540_c000_ops;
@@ -4432,16 +4434,26 @@ static int fu540_c000_clk_init(struct platform_device *pdev, struct clk **pclk, 
	mgmt->hw.init = &init;



	*tx_clk = devm_clk_register(&pdev->dev, &mgmt->hw);

	if (IS_ERR(*tx_clk))

		return PTR_ERR(*tx_clk);

	if (IS_ERR(*tx_clk)) {

		err = PTR_ERR(*tx_clk);

		goto err_disable_clks;

	}



	err = clk_prepare_enable(*tx_clk);

	if (err)

	if (err) {

		dev_err(&pdev->dev, "failed to enable tx_clk (%u)\n", err);

	else

		*tx_clk = NULL;

		goto err_disable_clks;

	} else {

		dev_info(&pdev->dev, "Registered clk switch '%s'\n", init.name);

	}



	return 0;



err_disable_clks:

	macb_clks_disable(*pclk, *hclk, *tx_clk, *rx_clk, *tsu_clk);



	return err;

}



static int fu540_c000_init(struct platform_device *pdev)

CRA Git | Maintained and supported by SUSTech CRA and CCSE