Unverified Commit f4d95de4 authored Feb 10, 2020 by Colin Ian King Committed by Mark Brown Feb 11, 2020

ASoC: ti: davinci-mcasp: remove redundant assignment to variable ret



The assignment to ret is redundant as it is not used in the error
return path and hence can be removed.

Addresses-Coverity: ("Unused value")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
Link: https://lore.kernel.org/r/20200210092423.327499-1-colin.king@canonical.com


Signed-off-by: Mark Brown <broonie@kernel.org>

parent da22a953

sound/soc/ti/davinci-mcasp.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1765,10 +1765,8 @@ static struct davinci_mcasp_pdata *davinci_mcasp_set_pdata_from_of(
		} else if (match) {
		pdata = devm_kmemdup(&pdev->dev, match->data, sizeof(*pdata),
		GFP_KERNEL);
		if (!pdata) {
		ret = -ENOMEM;
		return pdata;
		}
		if (!pdata)
		return NULL;
		} else {
		/* control shouldn't reach here. something is wrong */
		ret = -EINVAL;

Admin message