drm/mxsfb: Make supported modifiers explicit (f4b29bf7) · Commits · 戴 / test

In contrast to other display controllers on imx like DCSS and ipuv3 lcdif/mxsfb does not support detiling e.g. vivante tiled layouts. Since mesa might assume otherwise make it explicit that only DRM_FORMAT_MOD_LINEAR is supported. Signed-off-by:

Guido Günther <agx@sigxcpu.org> Reviewed-by:

Lucas Stach <l.stach@pengutronix.de> Signed-off-by:

Stefan Agner <stefan@agner.ch> Link: https://patchwork.freedesktop.org/patch/msgid/26877532e272c12a74c33188e2a72abafc9a2e1c.1584973664.git.agx@sigxcpu.org

drivers/gpu/drm/mxsfb/mxsfb_drv.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -69,6 +69,11 @@ static const uint32_t mxsfb_formats[] = {
		DRM_FORMAT_RGB565
		};

		static const uint64_t mxsfb_modifiers[] = {
		DRM_FORMAT_MOD_LINEAR,
		DRM_FORMAT_MOD_INVALID
		};

		static struct mxsfb_drm_private *
		drm_pipe_to_mxsfb_drm_private(struct drm_simple_display_pipe *pipe)
		{
		@@ -244,8 +249,8 @@ static int mxsfb_load(struct drm_device *drm, unsigned long flags)
		}

		ret = drm_simple_display_pipe_init(drm, &mxsfb->pipe, &mxsfb_funcs,
		mxsfb_formats, ARRAY_SIZE(mxsfb_formats), NULL,
		mxsfb->connector);
		mxsfb_formats, ARRAY_SIZE(mxsfb_formats),
		mxsfb_modifiers, mxsfb->connector);
		if (ret < 0) {
		dev_err(drm->dev, "Cannot setup simple display pipe\n");
		goto err_vblank;

Admin message