Commit f4b1363c authored by Josef Bacik's avatar Josef Bacik Committed by David Sterba
Browse files

btrfs: do not do delalloc reservation under page lock 



We ran into a deadlock in production with the fixup worker.  The stack
traces were as follows:

Thread responsible for the writeout, waiting on the page lock

  [<0>] io_schedule+0x12/0x40
  [<0>] __lock_page+0x109/0x1e0
  [<0>] extent_write_cache_pages+0x206/0x360
  [<0>] extent_writepages+0x40/0x60
  [<0>] do_writepages+0x31/0xb0
  [<0>] __writeback_single_inode+0x3d/0x350
  [<0>] writeback_sb_inodes+0x19d/0x3c0
  [<0>] __writeback_inodes_wb+0x5d/0xb0
  [<0>] wb_writeback+0x231/0x2c0
  [<0>] wb_workfn+0x308/0x3c0
  [<0>] process_one_work+0x1e0/0x390
  [<0>] worker_thread+0x2b/0x3c0
  [<0>] kthread+0x113/0x130
  [<0>] ret_from_fork+0x35/0x40
  [<0>] 0xffffffffffffffff

Thread of the fixup worker who is holding the page lock

  [<0>] start_delalloc_inodes+0x241/0x2d0
  [<0>] btrfs_start_delalloc_roots+0x179/0x230
  [<0>] btrfs_alloc_data_chunk_ondemand+0x11b/0x2e0
  [<0>] btrfs_check_data_free_space+0x53/0xa0
  [<0>] btrfs_delalloc_reserve_space+0x20/0x70
  [<0>] btrfs_writepage_fixup_worker+0x1fc/0x2a0
  [<0>] normal_work_helper+0x11c/0x360
  [<0>] process_one_work+0x1e0/0x390
  [<0>] worker_thread+0x2b/0x3c0
  [<0>] kthread+0x113/0x130
  [<0>] ret_from_fork+0x35/0x40
  [<0>] 0xffffffffffffffff

Thankfully the stars have to align just right to hit this.  First you
have to end up in the fixup worker, which is tricky by itself (my
reproducer does DIO reads into a MMAP'ed region, so not a common
operation).  Then you have to have less than a page size of free data
space and 0 unallocated space so you go down the "commit the transaction
to free up pinned space" path.  This was accomplished by a random
balance that was running on the host.  Then you get this deadlock.

I'm still in the process of trying to force the deadlock to happen on
demand, but I've hit other issues.  I can still trigger the fixup worker
path itself so this patch has been tested in that regard, so the normal
case is fine.

Fixes: 87826df0 ("btrfs: delalloc for page dirtied out-of-band in fixup worker")
Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 5ab58055

fs/btrfs/inode.c

+60 −16
Original line number Diff line number Diff line
@@ -2189,6 +2189,7 @@ int btrfs_set_extent_delalloc(struct inode *inode, u64 start, u64 end, 
/* see btrfs_writepage_start_hook for details on why this is required */

struct btrfs_writepage_fixup {

	struct page *page;

	struct inode *inode;

	struct btrfs_work work;

};
@@ -2203,9 +2204,20 @@ static void btrfs_writepage_fixup_worker(struct btrfs_work *work) 
	u64 page_start;

	u64 page_end;

	int ret = 0;

	bool free_delalloc_space = true;



	fixup = container_of(work, struct btrfs_writepage_fixup, work);

	page = fixup->page;

	inode = fixup->inode;

	page_start = page_offset(page);

	page_end = page_offset(page) + PAGE_SIZE - 1;



	/*

	 * This is similar to page_mkwrite, we need to reserve the space before

	 * we take the page lock.

	 */

	ret = btrfs_delalloc_reserve_space(inode, &data_reserved, page_start,

					   PAGE_SIZE);

again:

	lock_page(page);
@@ -2214,25 +2226,48 @@ again: 
	 * page->mapping may go NULL, but it shouldn't be moved to a different

	 * address space.

	 */

	if (!page->mapping || !PageDirty(page) || !PageChecked(page))

	if (!page->mapping || !PageDirty(page) || !PageChecked(page)) {

		/*

		 * Unfortunately this is a little tricky, either

		 *

		 * 1) We got here and our page had already been dealt with and

		 *    we reserved our space, thus ret == 0, so we need to just

		 *    drop our space reservation and bail.  This can happen the

		 *    first time we come into the fixup worker, or could happen

		 *    while waiting for the ordered extent.

		 * 2) Our page was already dealt with, but we happened to get an

		 *    ENOSPC above from the btrfs_delalloc_reserve_space.  In

		 *    this case we obviously don't have anything to release, but

		 *    because the page was already dealt with we don't want to

		 *    mark the page with an error, so make sure we're resetting

		 *    ret to 0.  This is why we have this check _before_ the ret

		 *    check, because we do not want to have a surprise ENOSPC

		 *    when the page was already properly dealt with.

		 */

		if (!ret) {

			btrfs_delalloc_release_extents(BTRFS_I(inode),

						       PAGE_SIZE);

			btrfs_delalloc_release_space(inode, data_reserved,

						     page_start, PAGE_SIZE,

						     true);

		}

		ret = 0;

		goto out_page;

	}



	/*

	 * We keep the PageChecked() bit set until we're done with the

	 * btrfs_start_ordered_extent() dance that we do below.  That drops and

	 * retakes the page lock, so we don't want new fixup workers queued for

	 * this page during the churn.

	 * We can't mess with the page state unless it is locked, so now that

	 * it is locked bail if we failed to make our space reservation.

	 */

	inode = page->mapping->host;

	page_start = page_offset(page);

	page_end = page_offset(page) + PAGE_SIZE - 1;

	if (ret)

		goto out_page;



	lock_extent_bits(&BTRFS_I(inode)->io_tree, page_start, page_end,

			 &cached_state);



	/* already ordered? We're done */

	if (PagePrivate2(page))

		goto out;

		goto out_reserved;



	ordered = btrfs_lookup_ordered_range(BTRFS_I(inode), page_start,

					PAGE_SIZE);
@@ -2245,11 +2280,6 @@ again: 
		goto again;

	}



	ret = btrfs_delalloc_reserve_space(inode, &data_reserved, page_start,

					   PAGE_SIZE);

	if (ret)

		goto out;



	ret = btrfs_set_extent_delalloc(inode, page_start, page_end, 0,

					&cached_state);

	if (ret)
@@ -2263,12 +2293,12 @@ again: 
	 * The page was dirty when we started, nothing should have cleaned it.

	 */

	BUG_ON(!PageDirty(page));

	free_delalloc_space = false;

out_reserved:

	btrfs_delalloc_release_extents(BTRFS_I(inode), PAGE_SIZE);

	if (ret)

	if (free_delalloc_space)

		btrfs_delalloc_release_space(inode, data_reserved, page_start,

					     PAGE_SIZE, true);

out:

	unlock_extent_cached(&BTRFS_I(inode)->io_tree, page_start, page_end,

			     &cached_state);

out_page:
@@ -2287,6 +2317,12 @@ out_page: 
	put_page(page);

	kfree(fixup);

	extent_changeset_free(data_reserved);

	/*

	 * As a precaution, do a delayed iput in case it would be the last iput

	 * that could need flushing space. Recursing back to fixup worker would

	 * deadlock.

	 */

	btrfs_add_delayed_iput(inode);

}



/*
@@ -2324,10 +2360,18 @@ int btrfs_writepage_cow_fixup(struct page *page, u64 start, u64 end) 
	if (!fixup)

		return -EAGAIN;



	/*

	 * We are already holding a reference to this inode from

	 * write_cache_pages.  We need to hold it because the space reservation

	 * takes place outside of the page lock, and we can't trust

	 * page->mapping outside of the page lock.

	 */

	ihold(inode);

	SetPageChecked(page);

	get_page(page);

	btrfs_init_work(&fixup->work, btrfs_writepage_fixup_worker, NULL, NULL);

	fixup->page = page;

	fixup->inode = inode;

	btrfs_queue_work(fs_info->fixup_workers, &fixup->work);



	return -EAGAIN;

CRA Git | Maintained and supported by SUSTech CRA and CCSE