Commit f4af3f82 authored Jul 13, 2017 by Heinz Mauelshagen Committed by Mike Snitzer Jul 25, 2017

dm raid: fix activation check in validate_raid_redundancy()



During growing reshapes (i.e. stripes being added to a raid set), the
new stripe images are not in-sync and not part of the raid set until
the reshape is started.

LVM2 has to request multiple table reloads involving superblock updates
in order to reflect proper size of SubLVs in the cluster.  Before a stripe
adding reshape starts, validate_raid_redundancy() fails as a result of that
because it checks the total number of devices against the number of rebuild
ones rather than the actual ones in the raid set (as retrieved from the
superblock) thus resulting in failed raid4/5/6/10 redundancy checks.

E.g. convert 3 stripes -> 7 stripes raid5 (which only allows for maximum
1 device to fail) requesting +4 delta disks causing 4 devices to rebuild
during reshaping thus failing activation.

To fix this, move validate_raid_redundancy() to get access to the
current raid_set members.

Signed-off-by: Heinz Mauelshagen <heinzm@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>

parent bbac1e06

drivers/md/dm-raid.c

+5 −5

Original line number	Diff line number	Diff line
		@@ -2541,11 +2541,6 @@ static int analyse_superblocks(struct dm_target ti, struct raid_set rs)
		if (!freshest)
		return 0;

		if (validate_raid_redundancy(rs)) {
		rs->ti->error = "Insufficient redundancy to activate array";
		return -EINVAL;
		}

		/*
		* Validation of the freshest device provides the source of
		* validation for the remaining devices.
		@@ -2554,6 +2549,11 @@ static int analyse_superblocks(struct dm_target ti, struct raid_set rs)
		if (super_validate(rs, freshest))
		return -EINVAL;

		if (validate_raid_redundancy(rs)) {
		rs->ti->error = "Insufficient redundancy to activate array";
		return -EINVAL;
		}

		rdev_for_each(rdev, mddev)
		if (!test_bit(Journal, &rdev->flags) &&
		rdev != freshest &&

Admin message