Commit f4a551b7 authored May 09, 2018 by David Hildenbrand Committed by Christian Borntraeger May 17, 2018

KVM: s390: vsie: fix < 8k check for the itdba



By missing an "L", we might detect some addresses to be <8k,
although they are not.

e.g. for itdba = 100001fff
!(gpa & ~0x1fffU) -> 1
!(gpa & ~0x1fffUL) -> 0

So we would report a SIE validity intercept although everything is fine.

Fixes: 166ecb3d ("KVM: s390: vsie: support transactional execution")
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Janosch Frank <frankja@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Janosch Frank <frankja@linux.ibm.com>
Cc: stable@vger.kernel.org # v4.8+
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>

parent 75bc37fe

arch/s390/kvm/vsie.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -578,7 +578,7 @@ static int pin_blocks(struct kvm_vcpu vcpu, struct vsie_page vsie_page)

		gpa = READ_ONCE(scb_o->itdba) & ~0xffUL;
		if (gpa && (scb_s->ecb & ECB_TE)) {
		if (!(gpa & ~0x1fffU)) {
		if (!(gpa & ~0x1fffUL)) {
		rc = set_validity_icpt(scb_s, 0x0080U);
		goto unpin;
		}

Admin message