rtw88: assign NULL to skb after being kfree()'ed (f48abf06) · Commits · 戴 / test

Should assign NULL to skb after kfree(), in case of driver trying to free the same skb again. This could happen if driver failed to allocate an skb when building reserved page. Signed-off-by:

Yan-Hsuan Chuang <yhchuang@realtek.com> Signed-off-by:

Kalle Valo <kvalo@codeaurora.org>

drivers/net/wireless/realtek/rtw88/fw.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1139,13 +1139,16 @@ static u8 rtw_build_rsvd_page(struct rtw_dev rtwdev,
		page += rtw_len_to_page(rsvd_pkt->skb->len, page_size);

		kfree_skb(rsvd_pkt->skb);
		rsvd_pkt->skb = NULL;
		}

		return buf;

		release_skb:
		list_for_each_entry(rsvd_pkt, &rtwdev->rsvd_page_list, list)
		list_for_each_entry(rsvd_pkt, &rtwdev->rsvd_page_list, list) {
		kfree_skb(rsvd_pkt->skb);
		rsvd_pkt->skb = NULL;
		}

		return NULL;
		}

Admin message