Commit f4853e1c authored Feb 15, 2019 by Bartosz Golaszewski Committed by Greg Kroah-Hartman Feb 19, 2019

nvmem: core: don't check the return value of notifier chain call



blocking_notifier_call_chain() returns the value returned by the last
registered callback. A positive return value doesn't indicate an error
and an nvmem device should correctly register irrespective of any
notifier callback failures. Drop the retval check.

Fixes: bee1138b ("nvmem: add a notifier chain")
Cc: stable@vger.kernel.org
Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Acked-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent eadf2499

drivers/nvmem/core.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -688,9 +688,7 @@ struct nvmem_device nvmem_register(const struct nvmem_config config)
		if (rval)
		goto err_remove_cells;

		rval = blocking_notifier_call_chain(&nvmem_notifier, NVMEM_ADD, nvmem);
		if (rval)
		goto err_remove_cells;
		blocking_notifier_call_chain(&nvmem_notifier, NVMEM_ADD, nvmem);

		return nvmem;

Admin message