Commit f4817843 authored Feb 24, 2019 by Lubomir Rintel Committed by Greg Kroah-Hartman Feb 26, 2019

serial: 8250_of: assume reg-shift of 2 for mrvl,mmp-uart



There are two other drivers that bind to mrvl,mmp-uart and both of them
assume register shift of 2 bits. There are device trees that lack the
property and rely on that assumption.

If this driver wins the race to bind to those devices, it should behave
the same as the older deprecated driver.

Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent fe9ed6d2

drivers/tty/serial/8250/8250_of.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -130,6 +130,10 @@ static int of_platform_serial_setup(struct platform_device *ofdev,
		port->flags \|= UPF_IOREMAP;
		}

		/* Compatibility with the deprecated pxa driver and 8250_pxa drivers. */
		if (of_device_is_compatible(np, "mrvl,mmp-uart"))
		port->regshift = 2;

		/* Check for registers offset within the devices address range */
		if (of_property_read_u32(np, "reg-shift", &prop) == 0)
		port->regshift = prop;

Admin message