Commit f4747b9c authored Dec 22, 2018 by Colin Ian King Committed by Rafael J. Wysocki Dec 26, 2018

drivers: base: swnode: check if swnode is NULL before dereferencing it

The to_software_mode() macro can potentially return NULL, so also add
a NULL check on swnode before dereferencing it to avoid any NULL
pointer dereferences.

Detected by CoverityScan, CID#1476052 ("Explicit null dereferenced")

Fixes: 59abd836 (drivers: base: Introducing software nodes to the firmware node framework)
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent 1d8f062e

drivers/base/swnode.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -477,7 +477,8 @@ software_node_get_parent(const struct fwnode_handle *fwnode)
		{
		struct software_node *swnode = to_software_node(fwnode);

		return swnode->parent ? &swnode->parent->fwnode : NULL;
		return swnode ? (swnode->parent ? &swnode->parent->fwnode : NULL) :
		NULL;
		}

		struct fwnode_handle *

Admin message