Commit f46f2a31 authored Nov 16, 2020 by Christoph Hellwig Committed by Jens Axboe Dec 01, 2020

loop: do not call set_blocksize



set_blocksize is used by file systems to use their preferred buffer cache
block size.  Block drivers should not set it.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent ee763e21

drivers/block/loop.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1164,9 +1164,6 @@ static int loop_configure(struct loop_device *lo, fmode_t mode,
		size = get_loop_size(lo, file);
		loop_set_size(lo, size);

		set_blocksize(bdev, S_ISBLK(inode->i_mode) ?
		block_size(inode->i_bdev) : PAGE_SIZE);

		lo->lo_state = Lo_bound;
		if (part_shift)
		lo->lo_flags \|= LO_FLAGS_PARTSCAN;

Admin message