Commit f468a729 authored Feb 16, 2016 by Jiri Benc Committed by David S. Miller Feb 18, 2016

vxlan: do not use fdb in metadata mode

In metadata mode, the vxlan interface is not supposed to use the fdb control
plane but an external one (openvswitch or static routes). With the current
code, packets may leak into the fdb handling code which usually causes them
to be dropped anyway but may have strange side effects.

Just drop the packets directly when in metadata mode if the destination data
are not correctly provided on egress.

Signed-off-by: Jiri Benc <jbenc@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e60b13e4

drivers/net/vxlan.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -2171,9 +2171,11 @@ static netdev_tx_t vxlan_xmit(struct sk_buff skb, struct net_device dev)
		#endif
		}

		if (vxlan->flags & VXLAN_F_COLLECT_METADATA &&
		info && info->mode & IP_TUNNEL_INFO_TX) {
		if (vxlan->flags & VXLAN_F_COLLECT_METADATA) {
		if (info && info->mode & IP_TUNNEL_INFO_TX)
		vxlan_xmit_one(skb, dev, NULL, false);
		else
		kfree_skb(skb);
		return NETDEV_TX_OK;
		}

Admin message