rxrpc: Fix a memory leak in rxkad_verify_response() (f45d01f4) · Commits · 戴 / test

A ticket was not released after a call of the function "rxkad_decrypt_ticket" failed. Thus replace the jump target "temporary_error_free_resp" by "temporary_error_free_ticket". Fixes: ("rxrpc: Don't put crypto buffers on the stack") Signed-off-by:

Qiushi Wu <wu000273@umn.edu> Signed-off-by:

David Howells <dhowells@redhat.com> cc: Markus Elfring <Markus.Elfring@web.de>

net/rxrpc/rxkad.c

+1 −2

Original line number	Diff line number	Diff line
		@@ -1148,7 +1148,7 @@ static int rxkad_verify_response(struct rxrpc_connection *conn,
		ret = rxkad_decrypt_ticket(conn, skb, ticket, ticket_len, &session_key,
		&expiry, _abort_code);
		if (ret < 0)
		goto temporary_error_free_resp;
		goto temporary_error_free_ticket;

		/* use the session key from inside the ticket to decrypt the
		* response */
		@@ -1230,7 +1230,6 @@ protocol_error:

		temporary_error_free_ticket:
		kfree(ticket);
		temporary_error_free_resp:
		kfree(response);
		temporary_error:
		/* Ignore the response packet if we got a temporary error such as

Admin message