Commit f4524447 authored Aug 04, 2019 by Nishka Dasgupta Committed by Linus Walleij Aug 06, 2019

pinctrl: nomadik: abx500: Add of_node_put() before return



Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Link: https://lore.kernel.org/r/20190804155154.4916-1-nishkadg.linux@gmail.com


Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent ea8cf5c5

drivers/pinctrl/nomadik/pinctrl-abx500.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -815,6 +815,7 @@ static int abx500_dt_node_to_map(struct pinctrl_dev *pctldev,
		&reserved_maps, num_maps);
		if (ret < 0) {
		pinctrl_utils_free_map(pctldev, map, num_maps);
		of_node_put(np);
		return ret;
		}
		}

Admin message