kallsyms: add static qualifiers where missing (f43e9daa) · Commits · 戴 / test

Fix the following sparse warnings: scripts/kallsyms.c:65:5: warning: symbol 'token_profit' was not declared. Should it be static? scripts/kallsyms.c:68:15: warning: symbol 'best_table' was not declared. Should it be static? scripts/kallsyms.c:69:15: warning: symbol 'best_table_len' was not declared. Should it be static? Also, remove 'inline' from is_arm_mapping_symbol(). The compiler will inline it anyway when it is appropriate to do so. Signed-off-by:

Masahiro Yamada <yamada.masahiro@socionext.com>

scripts/kallsyms.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -62,11 +62,11 @@ static int all_symbols = 0;
		static int absolute_percpu = 0;
		static int base_relative = 0;

		int token_profit[0x10000];
		static int token_profit[0x10000];

		/* the table that holds the result of the compression */
		unsigned char best_table[256][2];
		unsigned char best_table_len[256];
		static unsigned char best_table[256][2];
		static unsigned char best_table_len[256];


		static void usage(void)
		@@ -80,7 +80,7 @@ static void usage(void)
		* This ignores the intensely annoying "mapping symbols" found
		* in ARM ELF files: $a, $t and $d.
		*/
		static inline int is_arm_mapping_symbol(const char *str)
		static int is_arm_mapping_symbol(const char *str)
		{
		return str[0] == '$' && strchr("axtd", str[1])
		&& (str[2] == '\0' \|\| str[2] == '.');

Admin message