Commit f42ea55b authored by Anthony Koo's avatar Anthony Koo Committed by Alex Deucher
Browse files

drm/amd/display: add separate of private hwss functions 



[Why]
Some function pointers in the hwss function pointer table are
meant to be hw sequencer entry points to be called from dc.

However some of those function pointers are not meant to
be entry points, but instead used as a code reuse/inheritance
tool called directly by other hwss functions, not by dc.

Therefore, we want a more clear separation of which functions
we determine to be interface functions vs the functions we
use within hwss.

[How]
DC interface functions will be stored in:
    struct hw_sequencer_funcs
Functions used within HWSS will be stored in:
    struct hwseq_private_funcs

Signed-off-by: default avatarAnthony Koo <Anthony.Koo@amd.com>
Reviewed-by: default avatarTony Cheng <Tony.Cheng@amd.com>
Acked-by: default avatarLeo Li <sunpeng.li@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 2b77dcc5

drivers/gpu/drm/amd/display/dc/core/dc.c

+6 −0
Original line number Diff line number Diff line
@@ -2004,6 +2004,12 @@ static void commit_planes_do_stream_update(struct dc *dc, 
				dc->hwss.update_info_frame(pipe_ctx);

			}



			if (stream_update->hdr_static_metadata &&

					stream->use_dynamic_meta &&

					dc->hwss.set_dmdata_attributes &&

					pipe_ctx->stream->dmdata_address.quad_part != 0)

				dc->hwss.set_dmdata_attributes(pipe_ctx);



			if (stream_update->gamut_remap)

				dc_stream_set_gamut_remap(dc, stream);

drivers/gpu/drm/amd/display/dc/core/dc_debug.c

+0 −1
Original line number Diff line number Diff line
@@ -33,7 +33,6 @@ 


#include "core_status.h"

#include "core_types.h"

#include "hw_sequencer.h"



#include "resource.h"

drivers/gpu/drm/amd/display/dc/core/dc_stream.c

+0 −3
Original line number Diff line number Diff line
@@ -33,9 +33,6 @@ 
#include "resource.h"

#include "ipp.h"

#include "timing_generator.h"

#if defined(CONFIG_DRM_AMD_DC_DCN)

#include "dcn10/dcn10_hw_sequencer.h"

#endif



#define DC_LOGGER dc->ctx->logger

drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.c

+1 −1
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ 


#include "dce_hwseq.h"

#include "reg_helper.h"

#include "hw_sequencer.h"

#include "hw_sequencer_private.h"

#include "core_types.h"



#define CTX \

drivers/gpu/drm/amd/display/dc/dce/dce_hwseq.h

+5 −1
Original line number Diff line number Diff line
@@ -25,7 +25,7 @@ 
#ifndef __DCE_HWSEQ_H__

#define __DCE_HWSEQ_H__



#include "hw_sequencer.h"

#include "dc_types.h"



#define BL_REG_LIST()\

	SR(LVTMA_PWRSEQ_CNTL), \
@@ -811,6 +811,10 @@ enum blnd_mode { 
	BLND_MODE_BLENDING,/* Alpha blending - blend 'current' and 'other' */

};



struct dce_hwseq;

struct pipe_ctx;

struct clock_source;



void dce_enable_fe_clock(struct dce_hwseq *hwss,

		unsigned int inst, bool enable);

CRA Git | Maintained and supported by SUSTech CRA and CCSE