Commit f42e4b33 authored Nov 29, 2019 by Colin Ian King Committed by Ben Skeggs Jan 15, 2020

drm/nouveau/nouveau: fix incorrect sizeof on args.src an args.dst



The sizeof is currently on args.src and args.dst and should be on
*args.src and *args.dst. Fortunately these sizes just so happen
to be the same size so it worked, however, this should be fixed
and it also cleans up static analysis warnings

Addresses-Coverity: ("sizeof not portable")
Fixes: f268307e ("nouveau: simplify nouveau_dmem_migrate_vma")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Ben Skeggs <bskeggs@redhat.com>

parent 48140495

drivers/gpu/drm/nouveau/nouveau_dmem.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -635,10 +635,10 @@ nouveau_dmem_migrate_vma(struct nouveau_drm *drm,
		unsigned long c, i;
		int ret = -ENOMEM;

		args.src = kcalloc(max, sizeof(args.src), GFP_KERNEL);
		args.src = kcalloc(max, sizeof(*args.src), GFP_KERNEL);
		if (!args.src)
		goto out;
		args.dst = kcalloc(max, sizeof(args.dst), GFP_KERNEL);
		args.dst = kcalloc(max, sizeof(*args.dst), GFP_KERNEL);
		if (!args.dst)
		goto out_free_src;

Admin message