Commit f413cbb3 authored by Luca Ceresoli's avatar Luca Ceresoli Committed by David S. Miller
Browse files

net: macb: fix error format in dev_err() 



Errors are negative numbers. Using %u shows them as very large positive
numbers such as 4294967277 that don't make sense. Use the %d format
instead, and get a much nicer -19.

Signed-off-by: default avatarLuca Ceresoli <luca@lucaceresoli.net>
Fixes: b48e0bab ("net: macb: Migrate to devm clock interface")
Fixes: 93b31f48 ("net/macb: unify clock management")
Fixes: 421d9df0 ("net/macb: merge at91_ether driver into macb driver")
Fixes: aead88bd ("net: ethernet: macb: Add support for rx_clk")
Fixes: f5473d1d ("net: macb: Support clock management for tsu_clk")
Acked-by: default avatarNicolas Ferre <nicolas.ferre@microchip.com>
Reviewed-by: default avatarAndrew Lunn <andrew@lunn.ch>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent feadc4b6

drivers/net/ethernet/cadence/macb_main.c

+8 −8
Original line number Diff line number Diff line
@@ -3343,7 +3343,7 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk, 
		if (!err)

			err = -ENODEV;



		dev_err(&pdev->dev, "failed to get macb_clk (%u)\n", err);

		dev_err(&pdev->dev, "failed to get macb_clk (%d)\n", err);

		return err;

	}
@@ -3352,7 +3352,7 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk, 
		if (!err)

			err = -ENODEV;



		dev_err(&pdev->dev, "failed to get hclk (%u)\n", err);

		dev_err(&pdev->dev, "failed to get hclk (%d)\n", err);

		return err;

	}
@@ -3370,31 +3370,31 @@ static int macb_clk_init(struct platform_device *pdev, struct clk **pclk, 


	err = clk_prepare_enable(*pclk);

	if (err) {

		dev_err(&pdev->dev, "failed to enable pclk (%u)\n", err);

		dev_err(&pdev->dev, "failed to enable pclk (%d)\n", err);

		return err;

	}



	err = clk_prepare_enable(*hclk);

	if (err) {

		dev_err(&pdev->dev, "failed to enable hclk (%u)\n", err);

		dev_err(&pdev->dev, "failed to enable hclk (%d)\n", err);

		goto err_disable_pclk;

	}



	err = clk_prepare_enable(*tx_clk);

	if (err) {

		dev_err(&pdev->dev, "failed to enable tx_clk (%u)\n", err);

		dev_err(&pdev->dev, "failed to enable tx_clk (%d)\n", err);

		goto err_disable_hclk;

	}



	err = clk_prepare_enable(*rx_clk);

	if (err) {

		dev_err(&pdev->dev, "failed to enable rx_clk (%u)\n", err);

		dev_err(&pdev->dev, "failed to enable rx_clk (%d)\n", err);

		goto err_disable_txclk;

	}



	err = clk_prepare_enable(*tsu_clk);

	if (err) {

		dev_err(&pdev->dev, "failed to enable tsu_clk (%u)\n", err);

		dev_err(&pdev->dev, "failed to enable tsu_clk (%d)\n", err);

		goto err_disable_rxclk;

	}
@@ -3868,7 +3868,7 @@ static int at91ether_clk_init(struct platform_device *pdev, struct clk **pclk, 


	err = clk_prepare_enable(*pclk);

	if (err) {

		dev_err(&pdev->dev, "failed to enable pclk (%u)\n", err);

		dev_err(&pdev->dev, "failed to enable pclk (%d)\n", err);

		return err;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE