Commit f40aa233 authored by Nikolay Aleksandrov's avatar Nikolay Aleksandrov Committed by David S. Miller
Browse files

net: bridge: set min MTU on port events and allow user to set max 



Recently the bridge was changed to automatically set maximum MTU on port
events (add/del/changemtu) when vlan filtering is enabled, but that
actually changes behaviour in a way which breaks some setups and can lead
to packet drops. In order to still allow that maximum to be set while being
compatible, we add the ability for the user to tune the bridge MTU up to
the maximum when vlan filtering is enabled, but that has to be done
explicitly and all port events (add/del/changemtu) lead to resetting that
MTU to the minimum as before.

Suggested-by: default avatarRoopa Prabhu <roopa@cumulusnetworks.com>
Signed-off-by: default avatarNikolay Aleksandrov <nikolay@cumulusnetworks.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 56c03cbf

net/bridge/br.c

+1 −1
Original line number Diff line number Diff line
@@ -52,7 +52,7 @@ static int br_device_event(struct notifier_block *unused, unsigned long event, v 


	switch (event) {

	case NETDEV_CHANGEMTU:

		dev_set_mtu(br->dev, br_mtu(br));

		dev_set_mtu(br->dev, br_mtu(br, false));

		break;



	case NETDEV_CHANGEADDR:

net/bridge/br_device.c

+2 −1
Original line number Diff line number Diff line
@@ -224,7 +224,8 @@ static void br_get_stats64(struct net_device *dev, 
static int br_change_mtu(struct net_device *dev, int new_mtu)

{

	struct net_bridge *br = netdev_priv(dev);

	if (new_mtu > br_mtu(br))



	if (new_mtu > br_mtu(br, br_vlan_enabled(dev)))

		return -EINVAL;



	dev->mtu = new_mtu;

net/bridge/br_if.c

+14 −29
Original line number Diff line number Diff line
@@ -424,41 +424,26 @@ int br_del_bridge(struct net *net, const char *name) 
	return ret;

}



static bool min_mtu(int a, int b)

{

	return a < b ? 1 : 0;

}



static bool max_mtu(int a, int b)

{

	return a > b ? 1 : 0;

}



/* MTU of the bridge pseudo-device: ETH_DATA_LEN or the minimum of the ports */

static int __br_mtu(const struct net_bridge *br, bool (compare_fn)(int, int))

/* MTU of the bridge pseudo-device: ETH_DATA_LEN if there are no ports, the

 * minimum of the ports if @max is false or the maximum if it's true

 */

int br_mtu(const struct net_bridge *br, bool max)

{

	const struct net_bridge_port *p;

	int mtu = 0;

	int ret_mtu = 0;



	ASSERT_RTNL();



	if (list_empty(&br->port_list))

		mtu = ETH_DATA_LEN;

	else {

	list_for_each_entry(p, &br->port_list, list) {

			if (!mtu || compare_fn(p->dev->mtu, mtu))

				mtu = p->dev->mtu;

		}

		if (!max) {

			if (!ret_mtu || ret_mtu > p->dev->mtu)

				ret_mtu = p->dev->mtu;

		} else if (p->dev->mtu > ret_mtu) {

			ret_mtu = p->dev->mtu;

		}

	return mtu;

	}



int br_mtu(const struct net_bridge *br)

{

	if (br_vlan_enabled(br->dev))

		return __br_mtu(br, max_mtu);

	else

		return __br_mtu(br, min_mtu);

	return ret_mtu ? ret_mtu : ETH_DATA_LEN;

}



static void br_set_gso_limits(struct net_bridge *br)
@@ -612,7 +597,7 @@ int br_add_if(struct net_bridge *br, struct net_device *dev, 
	if (changed_addr)

		call_netdevice_notifiers(NETDEV_CHANGEADDR, br->dev);



	dev_set_mtu(br->dev, br_mtu(br));

	dev_set_mtu(br->dev, br_mtu(br, false));

	br_set_gso_limits(br);



	kobject_uevent(&p->kobj, KOBJ_ADD);
@@ -659,7 +644,7 @@ int br_del_if(struct net_bridge *br, struct net_device *dev) 
	 */

	del_nbp(p);



	dev_set_mtu(br->dev, br_mtu(br));

	dev_set_mtu(br->dev, br_mtu(br, false));

	br_set_gso_limits(br);



	spin_lock_bh(&br->lock);

net/bridge/br_private.h

+1 −1
Original line number Diff line number Diff line
@@ -578,7 +578,7 @@ int br_del_bridge(struct net *net, const char *name); 
int br_add_if(struct net_bridge *br, struct net_device *dev,

	      struct netlink_ext_ack *extack);

int br_del_if(struct net_bridge *br, struct net_device *dev);

int br_mtu(const struct net_bridge *br);

int br_mtu(const struct net_bridge *br, bool max);

netdev_features_t br_features_recompute(struct net_bridge *br,

					netdev_features_t features);

void br_port_flags_change(struct net_bridge_port *port, unsigned long mask);

CRA Git | Maintained and supported by SUSTech CRA and CCSE