Commit f40386a4 authored Dec 12, 2013 by Naoya Horiguchi Committed by Linus Torvalds Dec 12, 2013

include/linux/hugetlb.h: make isolate_huge_page() an inline



With CONFIG_HUGETLBFS=n:

  mm/migrate.c: In function `do_move_page_to_node_array':
  include/linux/hugetlb.h:140:33: warning: statement with no effect [-Wunused-value]
   #define isolate_huge_page(p, l) false
                                   ^
  mm/migrate.c:1170:4: note: in expansion of macro `isolate_huge_page'
      isolate_huge_page(page, &pagelist);

Reported-by: Borislav Petkov <bp@alien8.de>
Tested-by: Borislav Petkov <bp@alien8.de>
Signed-off-by: Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>
Acked-by: David Rientjes <rientjes@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 846f29a6

include/linux/hugetlb.h

+4 −1

Original line number	Diff line number	Diff line
		@@ -142,7 +142,10 @@ static inline int dequeue_hwpoisoned_huge_page(struct page *page)
		return 0;
		}

		#define isolate_huge_page(p, l) false
		static inline bool isolate_huge_page(struct page page, struct list_head list)
		{
		return false;
		}
		#define putback_active_hugepage(p) do {} while (0)
		#define is_hugepage_active(x) false

Admin message