Commit f3fbbb07 authored by Aihua Zhang's avatar Aihua Zhang Committed by Miklos Szeredi
Browse files

fsnotify: support overlayfs 



When an event occurs direct it to the overlay inode instead of the real
underlying inode.

This will work even if the file was first on the lower layer and then
copied up, while the watch is there.  This is because the watch is on the
overlay inode, which stays the same through the copy-up.

For filesystems other than overlayfs this is a no-op, except for the
performance impact of an extra pointer dereferece.

Verified to work correctly with the inotify/fanotify tests in LTP.

Signed-off-by: default avatarAihua Zhang <zhangaihua1@huawei.com>
Signed-off-by: default avatarMiklos Szeredi <mszeredi@redhat.com>
Cc: Jan Kara <jack@suse.cz>
Cc: Eric Paris <eparis@redhat.com>
parent 598e3c8f

include/linux/fsnotify.h

+9 −5
Original line number Diff line number Diff line
@@ -29,7 +29,11 @@ static inline int fsnotify_parent(struct path *path, struct dentry *dentry, __u3 
static inline int fsnotify_perm(struct file *file, int mask)

{

	struct path *path = &file->f_path;

	struct inode *inode = file_inode(file);

	/*

	 * Do not use file_inode() here or anywhere in this file to get the

	 * inode.  That would break *notity on overlayfs.

	 */

	struct inode *inode = path->dentry->d_inode;

	__u32 fsnotify_mask = 0;

	int ret;
@@ -173,7 +177,7 @@ static inline void fsnotify_mkdir(struct inode *inode, struct dentry *dentry) 
static inline void fsnotify_access(struct file *file)

{

	struct path *path = &file->f_path;

	struct inode *inode = file_inode(file);

	struct inode *inode = path->dentry->d_inode;

	__u32 mask = FS_ACCESS;



	if (S_ISDIR(inode->i_mode))
@@ -191,7 +195,7 @@ static inline void fsnotify_access(struct file *file) 
static inline void fsnotify_modify(struct file *file)

{

	struct path *path = &file->f_path;

	struct inode *inode = file_inode(file);

	struct inode *inode = path->dentry->d_inode;

	__u32 mask = FS_MODIFY;



	if (S_ISDIR(inode->i_mode))
@@ -209,7 +213,7 @@ static inline void fsnotify_modify(struct file *file) 
static inline void fsnotify_open(struct file *file)

{

	struct path *path = &file->f_path;

	struct inode *inode = file_inode(file);

	struct inode *inode = path->dentry->d_inode;

	__u32 mask = FS_OPEN;



	if (S_ISDIR(inode->i_mode))
@@ -225,7 +229,7 @@ static inline void fsnotify_open(struct file *file) 
static inline void fsnotify_close(struct file *file)

{

	struct path *path = &file->f_path;

	struct inode *inode = file_inode(file);

	struct inode *inode = path->dentry->d_inode;

	fmode_t mode = file->f_mode;

	__u32 mask = (mode & FMODE_WRITE) ? FS_CLOSE_WRITE : FS_CLOSE_NOWRITE;

CRA Git | Maintained and supported by SUSTech CRA and CCSE