Commit f3ef6f63 authored Sep 06, 2005 by Karsten Wiese Committed by Linus Torvalds Sep 07, 2005

[PATCH] Speedup FAT filesystem directory reads



      OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>

This speeds up directory reads for large FAT partitions, if the buffercache
has to be filled from the drive. Following values were taken from:

        $ time find path_to_freshly_mounted_fat > /dev/null

on an otherwise idle system.

FAT with 16KB Clusters on IDE attached drive:   Factor  2
FAT with 32KB Clusters on USB2 attached drive:  Factor 10 (!)
Its less than 1/10 slower, if the buffercache is uptodate.

The patch introduces the new function fat_dir_readahead().

fat_dir_readahead() calls sb_breadahead() to readahead a whole cluster,
if the requested sector is the first one in a cluster.
It is usefull to do this, because on FAT directories occupy whole
clusters, with the exception of FAT12/FAT16 root dirs.

Readahead is only done, if the cluster's first sector is not uptodate
to avoid overhead, when the buffer cache is already uptodate.
Note that under memory pressure, the maximal byte count wasted
(read: has to be red from disk twice) is 1 cluster's size.  Thats 64KB.

fat_dir_readahead() is called from fat__get_entry().

There is also an unrelated cleanup at one spot:

        if (bh)
                brelse(bh);

is replaced with:

        brelse(bh);

brelse() can handle NULL pointer arguments by itself.

Signed-off-by: Karsten Wiese <annabellesgarden@yahoo.de>
Signed-off-by: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent 378bac82

fs/fat/dir.c

+26 −2

Original line number	Diff line number	Diff line
		@@ -30,6 +30,29 @@ static inline loff_t fat_make_i_pos(struct super_block *sb,
		\| (de - (struct msdos_dir_entry *)bh->b_data);
		}

		static inline void fat_dir_readahead(struct inode *dir, sector_t iblock,
		sector_t phys)
		{
		struct super_block *sb = dir->i_sb;
		struct msdos_sb_info *sbi = MSDOS_SB(sb);
		struct buffer_head *bh;
		int sec;

		/* This is not a first sector of cluster, or sec_per_clus == 1 */
		if ((iblock & (sbi->sec_per_clus - 1)) \|\| sbi->sec_per_clus == 1)
		return;
		/* root dir of FAT12/FAT16 */
		if ((sbi->fat_bits != 32) && (dir->i_ino == MSDOS_ROOT_INO))
		return;

		bh = sb_getblk(sb, phys);
		if (bh && !buffer_uptodate(bh)) {
		for (sec = 0; sec < sbi->sec_per_clus; sec++)
		sb_breadahead(sb, phys + sec);
		}
		brelse(bh);
		}

		/* Returns the inode number of the directory entry at offset pos. If bh is
		non-NULL, it is brelse'd before. Pos is incremented. The buffer header is
		returned in bh.
		@@ -58,6 +81,8 @@ next:
		if (err \|\| !phys)
		return -1; /* beyond EOF or error */

		fat_dir_readahead(dir, iblock, phys);

		*bh = sb_bread(sb, phys);
		if (*bh == NULL) {
		printk(KERN_ERR "FAT: Directory bread(block %llu) failed\n",
		@@ -635,7 +660,6 @@ RecEnd:
		EODir:
		filp->f_pos = cpos;
		FillFailed:
		if (bh)
		brelse(bh);
		if (unicode)
		free_page((unsigned long)unicode);

Admin message