Commit f3ec434c authored by Konstantin Shlyakhovoy's avatar Konstantin Shlyakhovoy Committed by Linus Torvalds
Browse files

drivers/rtc/rtc-twl.c: use static register while reading time 



RTC stores time and date in several registers.  Due to the fact that
these registers can't be read instantaneously, there is a chance that
reading from counting registers gives an error of one minute, one hour,
one day, etc.

To address this issue, the RTC has hardware support to copy the RTC
counting registers to static shadowed registers.  The current
implementation does not use this feature, and in a stress test, we can
reproduce this error at a rate of around two times per 300000 readings.

Fix the implementation to ensure that the right snapshot of time is
captured.

Signed-off-by: default avatarKonstantin Shlyakhovoy <x0155534@ti.com>
Signed-off-by: default avatarNishanth Menon <nm@ti.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Cc: Benoit Cousson <b-cousson@ti.com>
Cc: linux-omap <linux-omap@vger.kernel.org>
Acked-by: default avatarMykola Oleksiienko <x0174904@ti.com>
Acked-by: default avatarOleksandr Dmytryshyn <oleksandr.dmytryshyn@ti.com>
Acked-by: default avatarGraeme Gregory <gg@slimlogic.co.uk>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent c3cba928

drivers/rtc/rtc-twl.c

+38 −5
Original line number Diff line number Diff line
@@ -112,6 +112,7 @@ static const u8 twl6030_rtc_reg_map[] = { 
#define BIT_RTC_CTRL_REG_TEST_MODE_M             0x10

#define BIT_RTC_CTRL_REG_SET_32_COUNTER_M        0x20

#define BIT_RTC_CTRL_REG_GET_TIME_M              0x40

#define BIT_RTC_CTRL_REG_RTC_V_OPT               0x80



/* RTC_STATUS_REG bitfields */

#define BIT_RTC_STATUS_REG_RUN_M                 0x02
@@ -235,25 +236,57 @@ static int twl_rtc_read_time(struct device *dev, struct rtc_time *tm) 
	unsigned char rtc_data[ALL_TIME_REGS + 1];

	int ret;

	u8 save_control;

	u8 rtc_control;



	ret = twl_rtc_read_u8(&save_control, REG_RTC_CTRL_REG);

	if (ret < 0)

	if (ret < 0) {

		dev_err(dev, "%s: reading CTRL_REG, error %d\n", __func__, ret);

		return ret;

	}

	/* for twl6030/32 make sure BIT_RTC_CTRL_REG_GET_TIME_M is clear */

	if (twl_class_is_6030()) {

		if (save_control & BIT_RTC_CTRL_REG_GET_TIME_M) {

			save_control &= ~BIT_RTC_CTRL_REG_GET_TIME_M;

			ret = twl_rtc_write_u8(save_control, REG_RTC_CTRL_REG);

			if (ret < 0) {

				dev_err(dev, "%s clr GET_TIME, error %d\n",

					__func__, ret);

				return ret;

			}

		}

	}



	save_control |= BIT_RTC_CTRL_REG_GET_TIME_M;

	/* Copy RTC counting registers to static registers or latches */

	rtc_control = save_control | BIT_RTC_CTRL_REG_GET_TIME_M;



	ret = twl_rtc_write_u8(save_control, REG_RTC_CTRL_REG);

	if (ret < 0)

	/* for twl6030/32 enable read access to static shadowed registers */

	if (twl_class_is_6030())

		rtc_control |= BIT_RTC_CTRL_REG_RTC_V_OPT;



	ret = twl_rtc_write_u8(rtc_control, REG_RTC_CTRL_REG);

	if (ret < 0) {

		dev_err(dev, "%s: writing CTRL_REG, error %d\n", __func__, ret);

		return ret;

	}



	ret = twl_i2c_read(TWL_MODULE_RTC, rtc_data,

			(rtc_reg_map[REG_SECONDS_REG]), ALL_TIME_REGS);



	if (ret < 0) {

		dev_err(dev, "rtc_read_time error %d\n", ret);

		dev_err(dev, "%s: reading data, error %d\n", __func__, ret);

		return ret;

	}



	/* for twl6030 restore original state of rtc control register */

	if (twl_class_is_6030()) {

		ret = twl_rtc_write_u8(save_control, REG_RTC_CTRL_REG);

		if (ret < 0) {

			dev_err(dev, "%s: restore CTRL_REG, error %d\n",

				__func__, ret);

			return ret;

		}

	}



	tm->tm_sec = bcd2bin(rtc_data[0]);

	tm->tm_min = bcd2bin(rtc_data[1]);

	tm->tm_hour = bcd2bin(rtc_data[2]);

CRA Git | Maintained and supported by SUSTech CRA and CCSE