cxl: drop the dma_set_mask callback from vphb (f3e5a857) · Commits · 戴 / test

The CXL code never even looks at the dma mask, so there is no good reason for this sanity check. Remove it because it gets in the way of the dma ops refactoring. Signed-off-by:

Christoph Hellwig <hch@lst.de> Acked-by:

Andrew Donnellan <andrew.donnellan@au1.ibm.com> Signed-off-by:

Michael Ellerman <mpe@ellerman.id.au>

drivers/misc/cxl/vphb.c

+0 −12

Original line number	Diff line number	Diff line
		@@ -11,17 +11,6 @@
		#include <misc/cxl.h>
		#include "cxl.h"

		static int cxl_dma_set_mask(struct pci_dev *pdev, u64 dma_mask)
		{
		if (dma_mask < DMA_BIT_MASK(64)) {
		pr_info("%s only 64bit DMA supported on CXL", __func__);
		return -EIO;
		}

		*(pdev->dev.dma_mask) = dma_mask;
		return 0;
		}

		static int cxl_pci_probe_mode(struct pci_bus *bus)
		{
		return PCI_PROBE_NORMAL;
		@@ -220,7 +209,6 @@ static struct pci_controller_ops cxl_pci_controller_ops =
		.reset_secondary_bus = cxl_pci_reset_secondary_bus,
		.setup_msi_irqs = cxl_setup_msi_irqs,
		.teardown_msi_irqs = cxl_teardown_msi_irqs,
		.dma_set_mask = cxl_dma_set_mask,
		};

		int cxl_pci_vphb_add(struct cxl_afu *afu)

Admin message