Commit f3dbd344 authored by Christoph Lameter's avatar Christoph Lameter Committed by Linus Torvalds
Browse files

[PATCH] zoned vm counters: split NR_ANON_PAGES off from NR_FILE_MAPPED 



The current NR_FILE_MAPPED is used by zone reclaim and the dirty load
calculation as the number of mapped pagecache pages.  However, that is not
true.  NR_FILE_MAPPED includes the mapped anonymous pages.  This patch
separates those and therefore allows an accurate tracking of the anonymous
pages per zone.

It then becomes possible to determine the number of unmapped pages per zone
and we can avoid scanning for unmapped pages if there are none.

Also it may now be possible to determine the mapped/unmapped ratio in
get_dirty_limit.  Isnt the number of anonymous pages irrelevant in that
calculation?

Note that this will change the meaning of the number of mapped pages reported
in /proc/vmstat /proc/meminfo and in the per node statistics.  This may affect
user space tools that monitor these counters!  NR_FILE_MAPPED works like
NR_FILE_DIRTY.  It is only valid for pagecache pages.

Signed-off-by: default avatarChristoph Lameter <clameter@sgi.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent bf02cf4b

drivers/base/node.c

+2 −0
Original line number Diff line number Diff line
@@ -71,6 +71,7 @@ static ssize_t node_read_meminfo(struct sys_device * dev, char * buf) 
		       "Node %d Writeback:    %8lu kB\n"

		       "Node %d FilePages:    %8lu kB\n"

		       "Node %d Mapped:       %8lu kB\n"

		       "Node %d AnonPages:    %8lu kB\n"

		       "Node %d Slab:         %8lu kB\n",

		       nid, K(i.totalram),

		       nid, K(i.freeram),
@@ -85,6 +86,7 @@ static ssize_t node_read_meminfo(struct sys_device * dev, char * buf) 
		       nid, K(ps.nr_writeback),

		       nid, K(node_page_state(nid, NR_FILE_PAGES)),

		       nid, K(node_page_state(nid, NR_FILE_MAPPED)),

		       nid, K(node_page_state(nid, NR_ANON_PAGES)),

		       nid, K(ps.nr_slab));

	n += hugetlb_report_node_meminfo(nid, buf + n);

	return n;

fs/proc/proc_misc.c

+2 −0
Original line number Diff line number Diff line
@@ -168,6 +168,7 @@ static int meminfo_read_proc(char *page, char **start, off_t off, 
		"SwapFree:     %8lu kB\n"

		"Dirty:        %8lu kB\n"

		"Writeback:    %8lu kB\n"

		"AnonPages:    %8lu kB\n"

		"Mapped:       %8lu kB\n"

		"Slab:         %8lu kB\n"

		"CommitLimit:  %8lu kB\n"
@@ -191,6 +192,7 @@ static int meminfo_read_proc(char *page, char **start, off_t off, 
		K(i.freeswap),

		K(ps.nr_dirty),

		K(ps.nr_writeback),

		K(global_page_state(NR_ANON_PAGES)),

		K(global_page_state(NR_FILE_MAPPED)),

		K(ps.nr_slab),

		K(allowed),

include/linux/mmzone.h

+2 −1
Original line number Diff line number Diff line
@@ -47,7 +47,8 @@ struct zone_padding { 
#endif



enum zone_stat_item {

	NR_FILE_MAPPED,	/* mapped into pagetables.

	NR_ANON_PAGES,	/* Mapped anonymous pages */

	NR_FILE_MAPPED,	/* pagecache pages mapped into pagetables.

			   only modified from process context */

	NR_FILE_PAGES,

	NR_VM_ZONE_STAT_ITEMS };

mm/page-writeback.c

+2 −1
Original line number Diff line number Diff line
@@ -111,7 +111,8 @@ static void get_writeback_state(struct writeback_state *wbs) 
{

	wbs->nr_dirty = read_page_state(nr_dirty);

	wbs->nr_unstable = read_page_state(nr_unstable);

	wbs->nr_mapped = global_page_state(NR_FILE_MAPPED);

	wbs->nr_mapped = global_page_state(NR_FILE_MAPPED) +

				global_page_state(NR_ANON_PAGES);

	wbs->nr_writeback = read_page_state(nr_writeback);

}

mm/rmap.c

+3 −2
Original line number Diff line number Diff line
@@ -455,7 +455,7 @@ static void __page_set_anon_rmap(struct page *page, 
	 * nr_mapped state can be updated without turning off

	 * interrupts because it is not modified via interrupt.

	 */

	__inc_zone_page_state(page, NR_FILE_MAPPED);

	__inc_zone_page_state(page, NR_ANON_PAGES);

}



/**
@@ -531,7 +531,8 @@ void page_remove_rmap(struct page *page) 
		 */

		if (page_test_and_clear_dirty(page))

			set_page_dirty(page);

		__dec_zone_page_state(page, NR_FILE_MAPPED);

		__dec_zone_page_state(page,

				PageAnon(page) ? NR_ANON_PAGES : NR_FILE_MAPPED);

	}

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE