Commit f3c9d0a3 authored Oct 15, 2020 by Dan Carpenter Committed by Linus Torvalds Oct 16, 2020

lib/test_hmm.c: fix an error code in dmirror_allocate_chunk()



This is supposed to return false on failure, not a negative error code.

Fixes: 170e38548b81 ("mm/hmm/test: use after free in dmirror_allocate_chunk()")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Ralph Campbell <rcampbell@nvidia.com>
Cc: Jerome Glisse <jglisse@redhat.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Dan Williams <dan.j.williams@intel.com>
Link: https://lkml.kernel.org/r/20201010200812.GA1886610@mwanda


Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent e1308161

lib/test_hmm.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -461,7 +461,7 @@ static bool dmirror_allocate_chunk(struct dmirror_device *mdevice,

		devmem = kzalloc(sizeof(*devmem), GFP_KERNEL);
		if (!devmem)
		return -ENOMEM;
		return false;

		res = request_free_mem_region(&iomem_resource, DEVMEM_CHUNK_SIZE,
		"hmm_dmirror");

Admin message