Drivers: tty: n_gsm.c: fixed 7 errors & 6 warnings that checkpatch complained (f3c909b4) · Commits · 戴 / test

Specifically: n_gsm.c:810: ERROR: space required before the open parenthesis '(' n_gsm.c:830: WARNING: line over 80 characters n_gsm.c:971: ERROR: trailing whitespace n_gsm.c:984: ERROR: code indent should use tabs where possible n_gsm.c:984: WARNING: please, no space before tabs n_gsm.c:984: WARNING: please, no spaces at the start of a line n_gsm.c:1141: WARNING: space prohibited before semicolon n_gsm.c:1743: ERROR: space required before the open brace '{' n_gsm.c:1744: WARNING: line over 80 characters n_gsm.c:1745: ERROR: code indent should use tabs where possible n_gsm.c:1746: ERROR: code indent should use tabs where possible n_gsm.c:2908: WARNING: line over 80 characters n_gsm.c:2912: ERROR: trailing whitespace Signed-off-by:

Aldo Iljazi <neonsync1@gmail.com> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/tty/n_gsm.c

+16 −13

Original line number	Diff line number	Diff line
		@@ -827,8 +827,8 @@ static int gsm_dlci_data_output(struct gsm_mux gsm, struct gsm_dlci dlci)
		switch (dlci->adaption) {
		case 1: /* Unstructured */
		break;
		case 2: /* Unstructed with modem bits. Always one byte as we never
		send inline break data */
		case 2: /* Unstructed with modem bits.
		Always one byte as we never send inline break data */
		*dp++ = gsm_encode_modem(dlci);
		break;
		}
		@@ -1741,7 +1741,8 @@ static void gsm_queue(struct gsm_mux *gsm)
		if ((gsm->control & ~PF) == UI)
		gsm->fcs = gsm_fcs_add_block(gsm->fcs, gsm->buf, gsm->len);
		if (gsm->encoding == 0) {
		/* WARNING: gsm->received_fcs is used for gsm->encoding = 0 only.
		/* WARNING: gsm->received_fcs is used for
		gsm->encoding = 0 only.
		In this case it contain the last piece of data
		required to generate final CRC */
		gsm->fcs = gsm_fcs_add(gsm->fcs, gsm->received_fcs);
		@@ -2904,8 +2905,10 @@ static int gsmtty_install(struct tty_driver driver, struct tty_struct tty)
		gsm = gsm_mux[mux];
		if (gsm->dead)
		return -EL2HLT;
		/* If DLCI 0 is not yet fully open return an error. This is ok from a locking
		perspective as we don't have to worry about this if DLCI0 is lost */
		/* If DLCI 0 is not yet fully open return an error.
		This is ok from a locking
		perspective as we don't have to worry about this
		if DLCI0 is lost */
		if (gsm->dlci[0] && gsm->dlci[0]->state != DLCI_OPEN)
		return -EL2NSYNC;
		dlci = gsm->dlci[line];

Admin message