Commit f3bdc59f authored Jul 13, 2020 by Lee Jones Committed by Martin K. Petersen Jul 15, 2020

scsi: ipr: Fix struct packed-not-aligned issues

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/ipr.h:1687:1: warning: alignment 1 of ‘struct ipr_dump_location_entry’ is less than 4 [-Wpacked-not-aligned]
 1687 | }__attribute__((packed));
 | ^
 drivers/scsi/ipr.h:1711:1: warning: alignment 1 of ‘struct ipr_driver_dump’ is less than 4 [-Wpacked-not-aligned]
 1711 | }__attribute__((packed));
 | ^

Link: https://lore.kernel.org/r/20200713080001.128044-15-lee.jones@linaro.org


Cc: Brian King <brking@us.ibm.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 4dc83399

drivers/scsi/ipr.h

+2 −2

Original line number	Diff line number	Diff line
		@@ -1684,7 +1684,7 @@ struct ipr_dump_entry_header {
		struct ipr_dump_location_entry {
		struct ipr_dump_entry_header hdr;
		u8 location[20];
		}__attribute__((packed));
		}__attribute__((packed, aligned (4)));

		struct ipr_dump_trace_entry {
		struct ipr_dump_entry_header hdr;
		@@ -1708,7 +1708,7 @@ struct ipr_driver_dump {
		struct ipr_dump_location_entry location_entry;
		struct ipr_dump_ioa_type_entry ioa_type_entry;
		struct ipr_dump_trace_entry trace_entry;
		}__attribute__((packed));
		}__attribute__((packed, aligned (4)));

		struct ipr_ioa_dump {
		struct ipr_dump_entry_header hdr;

Admin message