Commit f3b60796 authored Jan 06, 2014 by Lars-Peter Clausen Committed by Mark Brown Jan 07, 2014

ASoC: mxs: Don't set unused struct snd_pcm_hardware fields

The ASoC core assumes that the PCM component of the ASoC card transparently
moves data around and does not impose any restrictions on the memory layout or
the transfer speed. It ignores all fields from the snd_pcm_hardware struct for
the PCM driver that are related to this. Setting these fields in the PCM driver
might suggest otherwise though, so rather not set them.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Tested-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Mark Brown <broonie@linaro.org>

parent 2650bc4f

sound/soc/mxs/mxs-pcm.c

+0 −5

Original line number	Diff line number	Diff line
		@@ -36,11 +36,6 @@ static const struct snd_pcm_hardware snd_mxs_hardware = {
		SNDRV_PCM_INFO_RESUME \|
		SNDRV_PCM_INFO_INTERLEAVED \|
		SNDRV_PCM_INFO_HALF_DUPLEX,
		.formats = SNDRV_PCM_FMTBIT_S16_LE \|
		SNDRV_PCM_FMTBIT_S20_3LE \|
		SNDRV_PCM_FMTBIT_S24_LE,
		.channels_min = 2,
		.channels_max = 2,
		.period_bytes_min = 32,
		.period_bytes_max = 8192,
		.periods_min = 1,

Admin message