Commit f3a31a2b authored Mar 26, 2015 by Steve French

Don't ignore errors on encrypting password in SMBTcon



Although unlikely to fail (and tree connect does not commonly send
a password since SECMODE_USER is the default for most servers)
do not ignore errors on SMBNTEncrypt in SMB Tree Connect.

Reported by Coverity (CID 1226853)

Signed-off-by: Steve French <smfrench@gmail.com>
Acked-by: Shirish Pargaonkar <shirishpargaonkar@gmail.com>
Acked-by: Sachin Prabhu <sprabhu@redhat.com>
Reviewed-by: Jeff Layton <jlayton@poochiereds.net>

parent 75fdfc84

fs/cifs/connect.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -3696,6 +3696,12 @@ CIFSTCon(const unsigned int xid, struct cifs_ses *ses,
		#endif /* CIFS_WEAK_PW_HASH */
		rc = SMBNTencrypt(tcon->password, ses->server->cryptkey,
		bcc_ptr, nls_codepage);
		if (rc) {
		cifs_dbg(FYI, "%s Can't generate NTLM rsp. Error: %d\n",
		__func__, rc);
		cifs_buf_release(smb_buffer);
		return rc;
		}

		bcc_ptr += CIFS_AUTH_RESP_SIZE;
		if (ses->capabilities & CAP_UNICODE) {

Admin message