Commit f39e1769 authored May 20, 2016 by Joe Perches Committed by Linus Torvalds May 20, 2016

checkpatch: improve CONSTANT_COMPARISON test for structure members



A "." dereference to an all uppercase structure member can be
incorrectly reported as a CONSTANT_COMPARISON.

ie: "if (table[i].PANELID == tempdx)"

Fix it by checking for "." before the constant test.

Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 2d632745

scripts/checkpatch.pl

+1 −1

Original line number	Diff line number	Diff line
		@@ -4291,7 +4291,7 @@ sub process {
		my $comp = $3;
		my $to = $4;
		my $newcomp = $comp;
		if ($lead !~ /$Operators\s*$/ &&
		if ($lead !~ /(?:$Operators\|\.)\s*$/ &&
		$to !~ /^(?:Constant\|[A-Z_][A-Z0-9_]*)$/ &&
		WARN("CONSTANT_COMPARISON",
		"Comparisons should place the constant on the right side of the test\n" . $herecurr) &&

Admin message