Commit f38c7e3a authored Sep 25, 2020 by Jens Axboe

io_uring: ensure async buffered read-retry is setup properly



A previous commit for fixing up short reads botched the async retry
path, so we ended up going to worker threads more often than we should.
Fix this up, so retries work the way they originally were intended to.

Fixes: 227c0c96 ("io_uring: internally retry short reads")
Reported-by: Hao_Xu <haoxu@linux.alibaba.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 62c774ed

fs/io_uring.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -3172,10 +3172,8 @@ static int io_read(struct io_kiocb *req, bool force_nonblock,
		goto done;
		/* some cases will consume bytes even on error returns */
		iov_iter_revert(iter, iov_count - iov_iter_count(iter));
		ret = io_setup_async_rw(req, iovec, inline_vecs, iter, false);
		if (ret)
		goto out_free;
		return -EAGAIN;
		ret = 0;
		goto copy_iov;
		} else if (ret < 0) {
		/* make sure -ERESTARTSYS -> -EINTR is done */
		goto done;

Admin message