Commit f38b0820 authored Jun 02, 2009 by Paul Mackerras Committed by Ingo Molnar Jun 02, 2009

perf_counter: Initialize per-cpu context earlier on cpu up



This arranges for perf_counter's notifier for cpu hotplug
operations to be called earlier than the migration notifier in
sched.c by increasing its priority to 20, compared to the 10
for the migration notifier.  The reason for doing this is that
a subsequent commit to convert the cpu migration counter to use
the generic swcounter infrastructure will add a call into the
perf_counter subsystem when tasks get migrated.  Therefore the
perf_counter subsystem needs a chance to initialize its per-cpu
data for the new cpu before it can get called from the
migration code.

This also adds a comment to the migration notifier noting that
its priority needs to be lower than that of the perf_counter
notifier.

Signed-off-by: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
LKML-Reference: <18981.1900.792795.836858@cargo.ozlabs.ibm.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>

parent 10a28255

kernel/perf_counter.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -3902,8 +3902,12 @@ perf_cpu_notify(struct notifier_block self, unsigned long action, void hcpu)
		return NOTIFY_OK;
		}

		/*
		* This has to have a higher priority than migration_notifier in sched.c.
		*/
		static struct notifier_block __cpuinitdata perf_cpu_nb = {
		.notifier_call = perf_cpu_notify,
		.priority = 20,
		};

		void __init perf_counter_init(void)

kernel/sched.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -7319,8 +7319,10 @@ migration_call(struct notifier_block nfb, unsigned long action, void hcpu)
		return NOTIFY_OK;
		}

		/* Register at highest priority so that task migration (migrate_all_tasks)
		* happens before everything else.
		/*
		* Register at high priority so that task migration (migrate_all_tasks)
		* happens before everything else. This has to be lower priority than
		* the notifier in the perf_counter subsystem, though.
		*/
		static struct notifier_block __cpuinitdata migration_notifier = {
		.notifier_call = migration_call,

Admin message