NFS: slight optimization for walking list for delegations (f3893491) · Commits · 戴 / test

There are 3 places where we walk the list of delegations for an nfs_client. In each case there are two nested loops, one for nfs_servers and one for nfs_delegations. When we find an interesting delegation we try to get an active reference to the server. If that fails, it is pointless to continue to look at the other delegation for the server as we will never be able to get an active reference. So instead of continuing in the inner loop, break out and continue in the outer loop. Signed-off-by:

NeilBrown <neilb@suse.com> Signed-off-by:

Trond Myklebust <trond.myklebust@hammerspace.com>

fs/nfs/delegation.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -495,7 +495,7 @@ restart:
		if (!nfs_delegation_need_return(delegation))
		continue;
		if (!nfs_sb_active(server->super))
		continue;
		break; /* continue in outer loop */
		inode = nfs_delegation_grab_inode(delegation);
		if (inode == NULL) {
		rcu_read_unlock();
		@@ -887,7 +887,7 @@ restart:
		&delegation->flags) == 0)
		continue;
		if (!nfs_sb_active(server->super))
		continue;
		break; /* continue in outer loop */
		inode = nfs_delegation_grab_inode(delegation);
		if (inode == NULL) {
		rcu_read_unlock();
		@@ -995,7 +995,7 @@ restart:
		&delegation->flags) == 0)
		continue;
		if (!nfs_sb_active(server->super))
		continue;
		break; /* continue in outer loop */
		inode = nfs_delegation_grab_inode(delegation);
		if (inode == NULL) {
		rcu_read_unlock();

Admin message