Commit f38173a7 authored by Hemant Kumar's avatar Hemant Kumar Committed by Greg Kroah-Hartman
Browse files

bus: mhi: core: Add const qualifier to MHI config information 



MHI channel, event and controller config data needs to be
treated read only information. Add const qualifier to make
sure config information passed by MHI controller is not
modified by MHI core driver.

Suggested-by: default avatarKalle Valo <kvalo@codeaurora.org>
Reviewed-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Signed-off-by: default avatarHemant Kumar <hemantk@codeaurora.org>
Signed-off-by: default avatarManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20200929175218.8178-12-manivannan.sadhasivam@linaro.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent f42dfbe8

drivers/bus/mhi/core/init.c

+6 −6
Original line number Diff line number Diff line
@@ -562,10 +562,10 @@ int mhi_init_chan_ctxt(struct mhi_controller *mhi_cntrl, 
}



static int parse_ev_cfg(struct mhi_controller *mhi_cntrl,

			struct mhi_controller_config *config)

			const struct mhi_controller_config *config)

{

	struct mhi_event *mhi_event;

	struct mhi_event_config *event_cfg;

	const struct mhi_event_config *event_cfg;

	struct device *dev = &mhi_cntrl->mhi_dev->dev;

	int i, num;
@@ -648,9 +648,9 @@ error_ev_cfg: 
}



static int parse_ch_cfg(struct mhi_controller *mhi_cntrl,

			struct mhi_controller_config *config)

			const struct mhi_controller_config *config)

{

	struct mhi_channel_config *ch_cfg;

	const struct mhi_channel_config *ch_cfg;

	struct device *dev = &mhi_cntrl->mhi_dev->dev;

	int i;

	u32 chan;
@@ -766,7 +766,7 @@ error_chan_cfg: 
}



static int parse_config(struct mhi_controller *mhi_cntrl,

			struct mhi_controller_config *config)

			const struct mhi_controller_config *config)

{

	int ret;
@@ -803,7 +803,7 @@ error_ev_cfg: 
}



int mhi_register_controller(struct mhi_controller *mhi_cntrl,

			    struct mhi_controller_config *config)

			    const struct mhi_controller_config *config)

{

	struct mhi_event *mhi_event;

	struct mhi_chan *mhi_chan;

include/linux/mhi.h

+3 −3
Original line number Diff line number Diff line
@@ -280,9 +280,9 @@ struct mhi_controller_config { 
	u32 timeout_ms;

	u32 buf_len;

	u32 num_channels;

	struct mhi_channel_config *ch_cfg;

	const struct mhi_channel_config *ch_cfg;

	u32 num_events;

	struct mhi_event_config *event_cfg;

	const struct mhi_event_config *event_cfg;

	bool use_bounce_buf;

	bool m2_no_db;

};
@@ -545,7 +545,7 @@ void mhi_free_controller(struct mhi_controller *mhi_cntrl); 
 * @config: Configuration to use for the controller

 */

int mhi_register_controller(struct mhi_controller *mhi_cntrl,

			    struct mhi_controller_config *config);

			const struct mhi_controller_config *config);



/**

 * mhi_unregister_controller - Unregister MHI controller

CRA Git | Maintained and supported by SUSTech CRA and CCSE