Commit f3637a5f authored Jul 07, 2011 by Sebastian Andrzej Siewior Committed by Thomas Gleixner Jul 28, 2011

irq: Always set IRQF_ONESHOT if no primary handler is specified



If no primary handler is specified then a default one is assigned
which always returns IRQ_WAKE_THREAD. This handler requires the
IRQF_ONESHOT flag on LEVEL / EIO typed irqs because the source of
interrupt is not disabled. Since it is required for those users and
there is no difference for others it makes sense to add this flag
unconditionally.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Link: http://lkml.kernel.org/r/1310070737-18514-1-git-send-email-bigeasy@linutronix.de


Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 1dd75f91

kernel/irq/manage.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1322,6 +1322,7 @@ int request_threaded_irq(unsigned int irq, irq_handler_t handler,
		if (!thread_fn)
		return -EINVAL;
		handler = irq_default_primary_handler;
		irqflags \|= IRQF_ONESHOT;
		}

		action = kzalloc(sizeof(struct irqaction), GFP_KERNEL);

Admin message