Commit f354169e authored Apr 13, 2015 by Anand Moon Committed by Guenter Roeck Apr 12, 2015

hwmon: (pwm-fan) Update the duty cycle inorder to control the pwm-fan



pwm_config() must be called with a duty cycle of 0 prior to calling
pwm_disable() to ensure that the pwm signal is set to low.

Reported-by: Markus Reichl <m.reichl@fivetechno.de>
Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
Reviewed-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

parent f83a9cb6

drivers/hwmon/pwm-fan.c

+3 −6

Original line number	Diff line number	Diff line
		@@ -47,23 +47,20 @@ static int __set_pwm(struct pwm_fan_ctx *ctx, unsigned long pwm)
		if (ctx->pwm_value == pwm)
		goto exit_set_pwm_err;

		if (pwm == 0) {
		pwm_disable(ctx->pwm);
		goto exit_set_pwm;
		}

		duty = DIV_ROUND_UP(pwm * (ctx->pwm->period - 1), MAX_PWM);
		ret = pwm_config(ctx->pwm, duty, ctx->pwm->period);
		if (ret)
		goto exit_set_pwm_err;

		if (pwm == 0)
		pwm_disable(ctx->pwm);

		if (ctx->pwm_value == 0) {
		ret = pwm_enable(ctx->pwm);
		if (ret)
		goto exit_set_pwm_err;
		}

		exit_set_pwm:
		ctx->pwm_value = pwm;
		exit_set_pwm_err:
		mutex_unlock(&ctx->lock);

Admin message