Commit f34fbb97 authored Dec 22, 2005 by Jaco Kroon Committed by David S. Miller Jan 03, 2006

[PKTGEN]: Deinitialise static variables.



static variables should not be explicitly initialised to 0.  This causes
them to be placed in .data instead of .bss.  This patch de-initialises 3
static variables in net/core/pktgen.c.

There are approximately 800 more such variables in the source tree
(2.6.15rc5).  If there is more interrest I'd be willing to track down the
rest of these as well and de-initialise them as well.

Signed-off-by: David S. Miller <davem@davemloft.net>

parent 90ddc4f0

net/core/pktgen.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -487,9 +487,9 @@ static unsigned int fmt_ip6(char *s,const char ip[16]);

		/* Module parameters, defaults. */
		static int pg_count_d = 1000; /* 1000 pkts by default */
		static int pg_delay_d = 0;
		static int pg_clone_skb_d = 0;
		static int debug = 0;
		static int pg_delay_d;
		static int pg_clone_skb_d;
		static int debug;

		static DECLARE_MUTEX(pktgen_sem);
		static struct pktgen_thread *pktgen_threads = NULL;

Admin message