Commit f34a6135 authored Apr 16, 2019 by Bob Peterson

gfs2: Only complain the first time an io error occurs in quota or log

Before this patch, all io errors received by the quota daemon or the
logd daemon would cause a complaint message to be issued, such as:

gfs2: fsid=dm-13.0: Error 10 writing to journal, jid=0

This patch changes it so that the error message is only issued the
first time the error is encountered.

Also, before this patch function gfs2_end_log_write did not set the
sd_log_error value, so log errors would not cause the file system to
be withdrawn. This patch sets the error code so the file system is
properly withdrawn if an io error is encountered writing to the journal.

WARNING: This change in function breaks check xfstests generic/441
and causes it to fail: io errors writing to the log should cause a
file system to be withdrawn, and no further operations are tolerated.

Signed-off-by: Bob Peterson <rpeterso@redhat.com>
Reviewed-by: Andreas Gruenbacher <agruenba@redhat.com>

parent 036330c9

fs/gfs2/lops.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -203,6 +203,7 @@ static void gfs2_end_log_write(struct bio *bio)
		struct bvec_iter_all iter_all;

		if (bio->bi_status) {
		if (!cmpxchg(&sdp->sd_log_error, 0, (int)bio->bi_status))
		fs_err(sdp, "Error %d writing to journal, jid=%u\n",
		bio->bi_status, sdp->sd_jdesc->jd_jid);
		wake_up(&sdp->sd_logd_waitq);

fs/gfs2/quota.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1476,8 +1476,8 @@ static void quotad_error(struct gfs2_sbd sdp, const char msg, int error)
		if (error == 0 \|\| error == -EROFS)
		return;
		if (!gfs2_withdrawn(sdp)) {
		if (!cmpxchg(&sdp->sd_log_error, 0, error))
		fs_err(sdp, "gfs2_quotad: %s error %d\n", msg, error);
		cmpxchg(&sdp->sd_log_error, 0, error);
		wake_up(&sdp->sd_logd_waitq);
		}
		}

Admin message