usb: gadget: amd5536udc: use free_dma_pools (f349dd3c) · Commits · 戴 / test

We have the function free_dma_pools() which frees all the dma pools. Use it instead of calling all the functions separately. The if conditions for data_requests and stp_requests are also not required here as this is the remove function and we are here means probe has succeeded and dma has been successfully allocated, so they cannot be NULL here. Signed-off-by:

Sudip Mukherjee <sudip@vectorindia.org> Signed-off-by:

Felipe Balbi <balbi@ti.com>

drivers/usb/gadget/udc/amd5536udc.c

+1 −14

Original line number	Diff line number	Diff line
		@@ -3131,20 +3131,7 @@ static void udc_pci_remove(struct pci_dev *pdev)
		return;

		/* dma pool cleanup */
		if (dev->data_requests)
		pci_pool_destroy(dev->data_requests);

		if (dev->stp_requests) {
		/* cleanup DMA desc's for ep0in */
		pci_pool_free(dev->stp_requests,
		dev->ep[UDC_EP0OUT_IX].td_stp,
		dev->ep[UDC_EP0OUT_IX].td_stp_dma);
		pci_pool_free(dev->stp_requests,
		dev->ep[UDC_EP0OUT_IX].td,
		dev->ep[UDC_EP0OUT_IX].td_phys);

		pci_pool_destroy(dev->stp_requests);
		}
		free_dma_pools(dev);

		/* reset controller */
		writel(AMD_BIT(UDC_DEVCFG_SOFTRESET), &dev->regs->cfg);

Admin message