Commit f34448cd authored Aug 02, 2020 by Tianjia Zhang Committed by Jens Axboe Aug 21, 2020

nvme-fc: Fix wrong return value in __nvme_fc_init_request()



On an error exit path, a negative error code should be returned
instead of a positive return value.

Fixes: e399441d ("nvme-fabrics: Add host support for FC transport")
Cc: James Smart <jsmart2021@gmail.com>
Signed-off-by: Tianjia Zhang <tianjia.zhang@linux.alibaba.com>
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 0ceeab96

drivers/nvme/host/fc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2078,7 +2078,7 @@ __nvme_fc_init_request(struct nvme_fc_ctrl *ctrl,
		if (fc_dma_mapping_error(ctrl->lport->dev, op->fcp_req.cmddma)) {
		dev_err(ctrl->dev,
		"FCP Op failed - cmdiu dma mapping failed.\n");
		ret = EFAULT;
		ret = -EFAULT;
		goto out_on_error;
		}

		@@ -2088,7 +2088,7 @@ __nvme_fc_init_request(struct nvme_fc_ctrl *ctrl,
		if (fc_dma_mapping_error(ctrl->lport->dev, op->fcp_req.rspdma)) {
		dev_err(ctrl->dev,
		"FCP Op failed - rspiu dma mapping failed.\n");
		ret = EFAULT;
		ret = -EFAULT;
		}

		atomic_set(&op->state, FCPOP_STATE_IDLE);

Admin message