Commit f333195d authored by Joe Perches's avatar Joe Perches Committed by Linus Torvalds
Browse files

checkpatch: don't test for prefer ether_addr_<foo> 

< sigh > Comment these tests out.

These are just too enticing to people that don't verify that
both source and dest addresses really must be __aligned(2).

It helps make Dan Carpenter happy too.

Link: http://lkml.kernel.org/r/dc32ec66d24647f4cdf824c8dfbbc59aa7ce7b7d.1472665676.git.joe@perches.com


Signed-off-by: default avatarJoe Perches <joe@perches.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg <gvrose8192@gmail.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 08eb9b80

scripts/checkpatch.pl

+35 −35
Original line number Diff line number Diff line
@@ -5554,46 +5554,46 @@ sub process { 
		}



# Check for memcpy(foo, bar, ETH_ALEN) that could be ether_addr_copy(foo, bar)

		if ($^V && $^V ge 5.10.0 &&

		    defined $stat &&

		    $stat =~ /^\+(?:.*?)\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) {

			if (WARN("PREFER_ETHER_ADDR_COPY",

				 "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)\n" . "$here\n$stat\n") &&

			    $fix) {

				$fixed[$fixlinenr] =~ s/\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/ether_addr_copy($2, $7)/;

			}

		}

#		if ($^V && $^V ge 5.10.0 &&

#		    defined $stat &&

#		    $stat =~ /^\+(?:.*?)\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) {

#			if (WARN("PREFER_ETHER_ADDR_COPY",

#				 "Prefer ether_addr_copy() over memcpy() if the Ethernet addresses are __aligned(2)\n" . "$here\n$stat\n") &&

#			    $fix) {

#				$fixed[$fixlinenr] =~ s/\bmemcpy\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/ether_addr_copy($2, $7)/;

#			}

#		}



# Check for memcmp(foo, bar, ETH_ALEN) that could be ether_addr_equal*(foo, bar)

		if ($^V && $^V ge 5.10.0 &&

		    defined $stat &&

		    $stat =~ /^\+(?:.*?)\bmemcmp\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) {

			WARN("PREFER_ETHER_ADDR_EQUAL",

			     "Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()\n" . "$here\n$stat\n")

		}

#		if ($^V && $^V ge 5.10.0 &&

#		    defined $stat &&

#		    $stat =~ /^\+(?:.*?)\bmemcmp\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) {

#			WARN("PREFER_ETHER_ADDR_EQUAL",

#			     "Prefer ether_addr_equal() or ether_addr_equal_unaligned() over memcmp()\n" . "$here\n$stat\n")

#		}



# check for memset(foo, 0x0, ETH_ALEN) that could be eth_zero_addr

# check for memset(foo, 0xFF, ETH_ALEN) that could be eth_broadcast_addr

		if ($^V && $^V ge 5.10.0 &&

		    defined $stat &&

		    $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) {



			my $ms_val = $7;



			if ($ms_val =~ /^(?:0x|)0+$/i) {

				if (WARN("PREFER_ETH_ZERO_ADDR",

					 "Prefer eth_zero_addr over memset()\n" . "$here\n$stat\n") &&

				    $fix) {

					$fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_zero_addr($2)/;

				}

			} elsif ($ms_val =~ /^(?:0xff|255)$/i) {

				if (WARN("PREFER_ETH_BROADCAST_ADDR",

					 "Prefer eth_broadcast_addr() over memset()\n" . "$here\n$stat\n") &&

				    $fix) {

					$fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_broadcast_addr($2)/;

				}

			}

		}

#		if ($^V && $^V ge 5.10.0 &&

#		    defined $stat &&

#		    $stat =~ /^\+(?:.*?)\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*\,\s*ETH_ALEN\s*\)/) {

#

#			my $ms_val = $7;

#

#			if ($ms_val =~ /^(?:0x|)0+$/i) {

#				if (WARN("PREFER_ETH_ZERO_ADDR",

#					 "Prefer eth_zero_addr over memset()\n" . "$here\n$stat\n") &&

#				    $fix) {

#					$fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_zero_addr($2)/;

#				}

#			} elsif ($ms_val =~ /^(?:0xff|255)$/i) {

#				if (WARN("PREFER_ETH_BROADCAST_ADDR",

#					 "Prefer eth_broadcast_addr() over memset()\n" . "$here\n$stat\n") &&

#				    $fix) {

#					$fixed[$fixlinenr] =~ s/\bmemset\s*\(\s*$FuncArg\s*,\s*$FuncArg\s*,\s*ETH_ALEN\s*\)/eth_broadcast_addr($2)/;

#				}

#			}

#		}



# typecasts on min/max could be min_t/max_t

		if ($^V && $^V ge 5.10.0 &&

CRA Git | Maintained and supported by SUSTech CRA and CCSE