Commit f2f0945e authored Sep 28, 2012 by Arnd Bergmann Committed by Jason Wessel Oct 12, 2012

tty/console: fix warnings in drivers/tty/serial/kgdboc.c



The con_debug_leave/con_debug_enter functions are stubbed out
by defining them to (0), which causes harmless build warnings.
Using proper inline functions is the normal way to deal with
this.

Without this patch, building the ARM bcm2835_defconfig results in:

drivers/tty/serial/kgdboc.c: In function 'kgdboc_pre_exp_handler':
drivers/tty/serial/kgdboc.c:279:3: warning: statement with no effect [-Wunused-value]
drivers/tty/serial/kgdboc.c: In function 'kgdboc_post_exp_handler':
drivers/tty/serial/kgdboc.c:293:3: warning: statement with no effect [-Wunused-value]

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Anton Vorontsov <anton.vorontsov@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>

parent 17b572e8

include/linux/console.h

+8 −2

Original line number	Diff line number	Diff line
		@@ -83,8 +83,14 @@ void give_up_console(const struct consw *sw);
		int con_debug_enter(struct vc_data *vc);
		int con_debug_leave(void);
		#else
		#define con_debug_enter(vc) (0)
		#define con_debug_leave() (0)
		static inline int con_debug_enter(struct vc_data *vc)
		{
		return 0;
		}
		static inline int con_debug_leave(void)
		{
		return 0;
		}
		#endif

		/* scroll */

Admin message