Commit f2edbb66 authored Oct 10, 2019 by Viresh Kumar

opp: of: drop incorrect lockdep_assert_held()



_find_opp_of_np() doesn't traverse the list of OPP tables but instead
just the entries within an OPP table and so only requires to lock the
OPP table itself.

The lockdep_assert_held() was added there by mistake and isn't really
required.

Fixes: 5d6d106f ("OPP: Populate required opp tables from "required-opps" property")
Cc: v5.0+ <stable@vger.kernel.org> # v5.0+
Reported-by: Niklas Cassel <niklas.cassel@linaro.org>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>

parent 54ecb8f7

drivers/opp/of.c

+0 −2

Original line number	Original line	Diff line number	Diff line
	@@ -77,8 +77,6 @@ static struct dev_pm_opp _find_opp_of_np(struct opp_table opp_table,
	{		{
	struct dev_pm_opp *opp;		struct dev_pm_opp *opp;

	lockdep_assert_held(&opp_table_lock);

	mutex_lock(&opp_table->lock);		mutex_lock(&opp_table->lock);

	list_for_each_entry(opp, &opp_table->opp_list, node) {		list_for_each_entry(opp, &opp_table->opp_list, node) {

Admin message