Commit f2d69760 authored by Wei Yongjun's avatar Wei Yongjun Committed by Greg Kroah-Hartman
Browse files

eeprom: idt_89hpesx: Drop kfree for memory allocated with devm_kzalloc 



It's not necessary to free memory allocated with devm_kzalloc
and using kfree leads to a double free.

Fixes: cfad6425 ("eeprom: Add IDT 89HPESx EEPROM/CSR driver")
Signed-off-by: default avatarWei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarSerge Semin <fancer.lancer@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent aed74b14

drivers/misc/eeprom/idt_89hpesx.c

+0 −4
Original line number Diff line number Diff line
@@ -1358,7 +1358,6 @@ static int idt_create_sysfs_files(struct idt_89hpesx_dev *pdev) 
	pdev->ee_file->size = pdev->eesize;

	ret = sysfs_create_bin_file(&dev->kobj, pdev->ee_file);

	if (ret != 0) {

		kfree(pdev->ee_file);

		dev_err(dev, "Failed to create EEPROM sysfs-node");

		return ret;

	}
@@ -1380,9 +1379,6 @@ static void idt_remove_sysfs_files(struct idt_89hpesx_dev *pdev) 


	/* Remove EEPROM sysfs file */

	sysfs_remove_bin_file(&dev->kobj, pdev->ee_file);



	/* Free memory allocated for bin_attribute structure */

	kfree(pdev->ee_file);

}



/*

CRA Git | Maintained and supported by SUSTech CRA and CCSE