Commit f2d47b55 authored by Trond Myklebust's avatar Trond Myklebust
Browse files

NFSv4: Update the stateid seqid in nfs_revoke_delegation()



If we revoke a delegation, but the stateid's seqid is newer, then
ensure we update the seqid when marking the delegation as revoked.

Signed-off-by: default avatarTrond Myklebust <trond.myklebust@hammerspace.com>
parent ae084a32
Loading
Loading
Loading
Loading
+13 −2
Original line number Diff line number Diff line
@@ -771,8 +771,19 @@ static bool nfs_revoke_delegation(struct inode *inode,
	if (stateid == NULL) {
		nfs4_stateid_copy(&tmp, &delegation->stateid);
		stateid = &tmp;
	} else if (!nfs4_stateid_match(stateid, &delegation->stateid))
	} else {
		if (!nfs4_stateid_match_other(stateid, &delegation->stateid))
			goto out;
		spin_lock(&delegation->lock);
		if (stateid->seqid) {
			if (nfs4_stateid_is_newer(&delegation->stateid, stateid)) {
				spin_unlock(&delegation->lock);
				goto out;
			}
			delegation->stateid.seqid = stateid->seqid;
		}
		spin_unlock(&delegation->lock);
	}
	nfs_mark_delegation_revoked(NFS_SERVER(inode), delegation);
	ret = true;
out: