Commit f2d04c32 authored Aug 14, 2013 by Julia Lawall Committed by Vinod Koul Aug 14, 2013

dma: mmp: simplify use of devm_ioremap_resource

Remove unneeded error handling on the result of a call to
platform_get_resource when the value is passed to devm_ioremap_resource.

A simplified version of the semantic patch that makes this change is as
follows: (http://coccinelle.lip6.fr/

)

// <smpl>
@@
expression pdev,res,n,e,e1;
expression ret != 0;
identifier l;
@@

- res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  ... when != res
- if (res == NULL) { ... \(goto l;\|return ret;\) }
  ... when != res
+ res = platform_get_resource(pdev, IORESOURCE_MEM, n);
  e = devm_ioremap_resource(e1, res);
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent 6fc4573c

drivers/dma/mmp_pdma.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -843,9 +843,6 @@ static int mmp_pdma_probe(struct platform_device *op)
		spin_lock_init(&pdev->phy_lock);

		iores = platform_get_resource(op, IORESOURCE_MEM, 0);
		if (!iores)
		return -EINVAL;

		pdev->base = devm_ioremap_resource(pdev->dev, iores);
		if (IS_ERR(pdev->base))
		return PTR_ERR(pdev->base);

drivers/dma/mmp_tdma.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -550,9 +550,6 @@ static int mmp_tdma_probe(struct platform_device *pdev)
		}

		iores = platform_get_resource(pdev, IORESOURCE_MEM, 0);
		if (!iores)
		return -EINVAL;

		tdev->base = devm_ioremap_resource(&pdev->dev, iores);
		if (IS_ERR(tdev->base))
		return PTR_ERR(tdev->base);

Admin message