sparc64: Fix cmdline_memory_size handling bugs. (f2b60794) · Commits · 戴 / test

First, lmb_enforce_memory_limit() interprets it's argument (mostly, heh) as a size limit not an address limit. So pass the raw cmdline_memory_size value into it. And we don't need to check it against zero, lmb_enforce_memory_limit() does that for us. Next, free_initmem() needs special handling when the kernel command line trims the available memory. The problem case is if the trimmed out memory is where the kernel image itself resides. When that memory is trimmed out, we don't add those physical ram areas to the sparsemem active ranges, amongst other things. Which means that this free_initmem() code will free up invalid page structs, resulting in either crashes or hangs. Just quick fix this by not freeing initmem at all if "mem=" was given on the boot command line. Signed-off-by:

David S. Miller <davem@davemloft.net>

arch/sparc64/mm/init.c

+19 −8

Original line number	Diff line number	Diff line
		@@ -1726,8 +1726,7 @@ void __init paging_init(void)

		find_ramdisk(phys_base);

		if (cmdline_memory_size)
		lmb_enforce_memory_limit(phys_base + cmdline_memory_size);
		lmb_enforce_memory_limit(cmdline_memory_size);

		lmb_analyze();
		lmb_dump_all();
		@@ -1964,6 +1963,15 @@ void __init mem_init(void)
		void free_initmem(void)
		{
		unsigned long addr, initend;
		int do_free = 1;

		/* If the physical memory maps were trimmed by kernel command
		* line options, don't even try freeing this initmem stuff up.
		* The kernel image could have been in the trimmed out region
		* and if so the freeing below will free invalid page structs.
		*/
		if (cmdline_memory_size)
		do_free = 0;

		/*
		* The init section is aligned to 8k in vmlinux.lds. Page align for >8k pagesizes.
		@@ -1978,6 +1986,8 @@ void free_initmem(void)
		((unsigned long) __va(kern_base)) -
		((unsigned long) KERNBASE));
		memset((void *)addr, POISON_FREE_INITMEM, PAGE_SIZE);

		if (do_free) {
		p = virt_to_page(page);

		ClearPageReserved(p);
		@@ -1987,6 +1997,7 @@ void free_initmem(void)
		totalram_pages++;
		}
		}
		}

		#ifdef CONFIG_BLK_DEV_INITRD
		void free_initrd_mem(unsigned long start, unsigned long end)

Admin message